Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency cycle #88

Closed
w6fux5 opened this issue Aug 28, 2022 · 2 comments
Closed

Dependency cycle #88

w6fux5 opened this issue Aug 28, 2022 · 2 comments

Comments

@w6fux5
Copy link

w6fux5 commented Aug 28, 2022

lib/auth.tsx
import { loginWithEmailAndPassword, ... } from '@/features/auth';

features/auth/components/LoginForm.tsx
import { useAuth } from '@/lib/auth';

Wouldn't this Dependency cycle?

@alan2207
Copy link
Owner

Hi there!

You are right, it is. As the matter of fact, this is not the only case in the app, there are more.
If you add the "import/no-cycle" rule to the eslint configuration, you can see them all.

This is something that has been overlooked when the app was initially built, but I am already aware of the issue and plan to update the application when I get the time to do so.

Thanks for reporting it.

@kaguya3222
Copy link

@alan2207 I believe lib layer should know nothing about features layer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants