Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix media player supported features for HA beta #2150

Merged
merged 2 commits into from
Dec 30, 2023

Conversation

Petro31
Copy link
Contributor

@Petro31 Petro31 commented Dec 28, 2023

Fixes change in 2024.1 for supported features.

Fixes #2149

@MJHeijster
Copy link

Thanks, hope it gets merged soon!

@alandtse
Copy link
Owner

alandtse commented Dec 28, 2023

I guess we need to bump hacs.json to set a new minimum version of HA.

Copy link
Owner

@alandtse alandtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump this line to cover the new HA version 2024.1. https://github.com/alandtse/alexa_media_player/blob/dev/hacs.json#L6. Also, can you check on the comment about the deprecation of MEDIA_TYPE_MUSIC. Ideally we can handle them all at the same time.

@airy10
Copy link

airy10 commented Dec 29, 2023

Just confirming that it's fixing it for me, including the updating of sensors devices attached to a player

@Petro31
Copy link
Contributor Author

Petro31 commented Dec 29, 2023

FYI, I didn't change STATE_UNAVAILABLE. That's supposed to be handled by the available property only, not in the state. I'll let you decide what to do with that.

When the state property returns None, the state will be translated to unknown. When the availability property returns False, the state will translate to unavailable.

@alandtse alandtse changed the title fix media player supported features fix: fix media player supported features for HA beta Dec 30, 2023
@alandtse alandtse merged commit 8d18e2a into alandtse:dev Dec 30, 2023
1 check passed
@alandtse
Copy link
Owner

Thanks!

alandtse added a commit that referenced this pull request Dec 30, 2023
fix: fix media player supported features for HA beta (#2150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alexa Media Player media player not available in new beta
5 participants