-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump teslajsonpy to 3.10.3 (#919) #942
Conversation
fix: bump teslajsonpy to 3.10.3 (alandtse#919)
Thanks. Are you able to run poetry update so it syncs the lock file? |
Sorry, I am not familiar with the poetry update process. Would you mind doing it? |
for more information, see https://pre-commit.ci
Unfortunately whatever fixes were included here appear to have broken the battery tests. Those will need to be fixed before it gets merged. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Removed the energy_left from the test data and updated the data calculation. Should be good to now. |
I mean unless the test isn't needed anymore because it's not in the API, removing a failing test isn't the way to address it. Can you please confirm you removed it because it's not in the API? |
I removed the energy left elements from the mock data and kept the test. The test is now using the same formula as what is used teslajsonpy. |
No description provided.