Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump teslajsonpy to 3.10.3 (#919) #942

Merged
merged 12 commits into from
Apr 14, 2024
Merged

fix: bump teslajsonpy to 3.10.3 (#919) #942

merged 12 commits into from
Apr 14, 2024

Conversation

gkwok1
Copy link
Contributor

@gkwok1 gkwok1 commented Apr 13, 2024

No description provided.

@alandtse
Copy link
Owner

Thanks. Are you able to run poetry update so it syncs the lock file?

@gkwok1
Copy link
Contributor Author

gkwok1 commented Apr 13, 2024

Thanks. Are you able to run poetry update so it syncs the lock file?

Sorry, I am not familiar with the poetry update process. Would you mind doing it?

@alandtse
Copy link
Owner

Unfortunately whatever fixes were included here appear to have broken the battery tests. Those will need to be fixed before it gets merged.

@gkwok1
Copy link
Contributor Author

gkwok1 commented Apr 14, 2024

Removed the energy_left from the test data and updated the data calculation. Should be good to now.

@alandtse
Copy link
Owner

I mean unless the test isn't needed anymore because it's not in the API, removing a failing test isn't the way to address it. Can you please confirm you removed it because it's not in the API?

@gkwok1
Copy link
Contributor Author

gkwok1 commented Apr 14, 2024

I removed the energy left elements from the mock data and kept the test. The test is now using the same formula as what is used teslajsonpy.

@alandtse alandtse merged commit a4aeb6c into alandtse:dev Apr 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants