perf: avoid creating a task for debounced listener update #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
changed the title
bdraco
force-pushed
the
useless_coro
branch
3 times, most recently
from
584bce8
to
087490e
Compare
bdraco
commented
Jun 8, 2024
| self._debounce_task = async_call_later( | ||
| self.hass, delay_since_last, partial(self._debounced, max_delay) | ||
| # Schedule the call to _async_debounced, pass max_delay using partial | ||
| self._cancel_debounce_timer = async_call_later( |
There was a problem hiding this comment.
async_call_later does not return a task, it returns a callback that can be used to cancel the timer
2 tasks
bdraco
changed the title
Nothing was being awaited in _debounced so it could be a normal function decorated with @callback to run in the event loop and did not need to be a coro. This avoids creating a task when the async_call_later fires
alandtse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing was being awaited in _debounced so it could be a normal function decorated with
@callbackto run in the event loop and did not need to be a coro. This avoids creating a task when the async_call_later firesNote as with #989, I don't use mqtt/teslamate so I have no real world test case for this