Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update russian translation #242

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

Blueberryy
Copy link
Contributor

Fixes and improvements

@andris86 andris86 merged commit 41b944a into alanedwardes:master Jul 23, 2024
alanedwardes added a commit that referenced this pull request Jul 29, 2024
@alanedwardes
Copy link
Owner

Thank you for the contribution - I have now merged this PR. I did remove one change though - you had the following:

#. Key:	CheckboxDisableSubtitles
#. SourceLocation:	/Game/Resources/Localisation/ST_Menus.ST_Menus
#: /Game/Resources/Localisation/ST_Menus.ST_Menus
msgctxt "Menus,CheckboxDisableSubtitles"
msgid "Disable Subtitles"
msgstr "Отключить субтитры"

#. Key:	CheckboxEnableClosedCaptions
#. SourceLocation:	/Game/Resources/Localisation/ST_Menus.ST_Menus
#: /Game/Resources/Localisation/ST_Menus.ST_Menus
msgctxt "Menus,CheckboxEnableClosedCaptions"
msgid "Enable Closed Captions"
msgstr "Включить субтитры"

I believe you have translated the above to "Disable Subtitles" and "Enable Subtitles". But that's not quite right, "Enable Closed Captions" isn't the same as "Enable Subtitles" -- closed captions is the audio description portion of the subtitle system, e.g. things like "[loud bang]", "[crash]", whereas subtitles is dialogue. So I reverted that translation back to what it was ("Включить скрытые субтитры").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants