Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

integration with nginx (docs) #88

Open
wants to merge 7 commits into
base: v2.2.x
Choose a base branch
from

Conversation

xpbe0
Copy link

@xpbe0 xpbe0 commented Jan 5, 2021

#87

Hola Alan, I troubleshooted the complete universe (endless hours) just to return to initial very simple nginx configuration. Perhaps may help others too..

Thanks a lot 👍 🍻
-Pete

@alangecker
Copy link
Owner

thanks for the pull request! ...and sorry, that it took so long that I manage to review it 😅

just two tiny points:

  1. Add the following directives to the https virtual host bbb.example.com this might be quite unclear to a lot of people what that means. Maybe rather explain to edit/create a file under /etc/nginx/sites-enabled?
  2. you enabled the cache. I'm not sure how the nginx cache works, but without having it specified further, wouldn't that mean that it caches every path including for example the BigBlueButton API - making it sometimes not working anymore? If yes, I think this should be disabled in this place and at some point rather added for specific locations in the nginx container (https://github.com/alangecker/bigbluebutton-docker/tree/v2.2.x/mod/nginx/bbb)

@xpbe0
Copy link
Author

xpbe0 commented Feb 19, 2021

Hello Alan, thanks for your remarks. I removed cache from nginx config for now and elaborated a bit on your other point.

manfred-w pushed a commit to manfred-w/bigbluebutton-docker that referenced this pull request May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants