Don't emit await keyword with ES transforms disabled (#624)

Follow-up to #623. With transforms disabled, we should just early return even in the async case.
alangpierce · Jun 20, 2021 · 6b6c0d7 · 6b6c0d7
1 parent edc56e0
commit 6b6c0d7
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/src/TokenProcessor.ts b/src/TokenProcessor.ts
@@ -212,9 +212,6 @@ export default class TokenProcessor {
       token.isAsyncOperation = isAsyncOperation(this);
     }
     if (this.disableESTransforms) {
-      if (token.isAsyncOperation) {
-        this.resultCode += "await ";
-      }
       return;
     }
     if (token.numNullishCoalesceStarts) {

diff --git a/test/sucrase-test.ts b/test/sucrase-test.ts
@@ -1302,7 +1302,7 @@ describe("sucrase", () => {
     );
   });
 
-  it("omits optional changing nullish transformations if ES transforms disabled", () => {
+  it("omits optional chaining nullish transformations if ES transforms disabled", () => {
     assertResult(
       `
       await navigator.share?.({});
@@ -1316,6 +1316,22 @@ describe("sucrase", () => {
     );
   });
 
+  it("properly skips optional chaining transform when the right-hand side uses await", () => {
+    assertResult(
+      `
+      async function foo() {
+        a?.b(await f());
+      }
+    `,
+      `
+      async function foo() {
+        a?.b(await f());
+      }
+    `,
+      {transforms: [], disableESTransforms: true},
+    );
+  });
+
   it("omits optional catch binding transformations if ES transforms disabled", () => {
     assertResult(
       `