Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSX fragments are broken #254

Closed
arv opened this issue Jun 16, 2018 · 2 comments
Closed

JSX fragments are broken #254

arv opened this issue Jun 16, 2018 · 2 comments
Assignees
@alangpierce

Comments

@arv
Copy link
Contributor

arv commented Jun 16, 2018

Empty fragments and fragments without whitespace do not work

https://sucrase.io/#selectedTransforms=jsx,imports&compareWithTypeScript=true&code=const%20c%20%3D%20%3C%3E%3C%2F%3E%3B%0A

https://sucrase.io/#selectedTransforms=jsx,imports&compareWithTypeScript=true&code=const%20c%20%3D%20%3C%3E%3Ca%2F%3E%3C%2F%3E%3B%0A
@alangpierce
Copy link
Owner

Thanks! Hopefully shouldn't be too bad to fix.

By the way, if you happen to know any significant open source projects that use JSX fragments, would be good to hear. Most of correctness issues in Sucrase have been found by running it on codebases I can find, and when I added fragment support I just wrote a few test cases myself, but obviously there were plenty of missing edge cases like these.

@arv
Copy link
Contributor Author

arv commented Jun 16, 2018

I don't know of any code base that uses them. You could just grab a few of the tests from Babel to ensure compatibility.

@alangpierce alangpierce self-assigned this Jun 25, 2018
alangpierce added a commit that referenced this issue Jun 26, 2018
@alangpierce
Fix off-by-one error in parsing JSX fragments
44f3b0e 
Fixes #254

`jsxParseOpeningElement` isn't supposed to parse the last token, but was doing
so, and it happened to work in the existing test cases.
alangpierce added a commit that referenced this issue Jun 26, 2018
@alangpierce
Fix off-by-one error in parsing JSX fragments
e484c69 
Fixes #254

`jsxParseOpeningElement` isn't supposed to parse the last token, but was doing
so, and it happened to work in the existing test cases.
@alangpierce alangpierce mentioned this issue Jun 26, 2018
Merged
alangpierce added a commit that referenced this issue Jun 26, 2018
@alangpierce
Fix off-by-one error in parsing JSX fragments (#275)
5acef1c 
Fixes #254

`jsxParseOpeningElement` isn't supposed to parse the last token, but was doing
so, and it happened to work in the existing test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alangpierce alangpierce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arv @alangpierce