Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle function name inference in named exports #308

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Properly handle function name inference in named exports #308

merged 1 commit into from
Aug 27, 2018

Commits on Aug 27, 2018

  1. Properly handle function name inference in named exports 

    Fixes #307

Instead of writing `exports.f = () => {};`, we write
`const f = () => {}; exports.f = f;` and still use `exports.f` for all writes
and reads. This is a little odd in that the variable is never used, but it makes
sure the export works fine. In the future, we possibly could refine it to only
do a special case when the RHS is an unnamed function, but that's a bit harder
to detect.
    @alangpierce
    alangpierce committed Aug 27, 2018
    Configuration menu
    Copy the full SHA
    57909ba View commit details
    Browse the repository at this point in the history