Change class field implementation to use initializer methods #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangpierce
force-pushed
the
change-class-fields-to-initializers
branch
from
c53ee84
to
c570fa2
Compare
|
Updated to use symbols instead of generated names. Otherwise, subclasses might define the same name and cause trouble. |
Fixes #311 Rather than moving the assignments to the constructor or after the class body, we now wrap them in methods that assign to either the instance or class (both via `this` assignments). The generated code in the constructor or after the class just calls those methods. This should make line numbers always line up and should make it possible to set debugger breakpoints in bound callback methods. It's slightly less correct, but hopefully that won't come up in practice.
alangpierce
force-pushed
the
change-class-fields-to-initializers
branch
from
c570fa2
to
f1df8f7
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #311
Rather than moving the assignments to the constructor or after the class body,
we now wrap them in methods that assign to either the instance or class (both
via
thisassignments). The generated code in the constructor or after theclass just calls those methods.
This should make line numbers always line up and should make it possible to set
debugger breakpoints in bound callback methods. It's slightly less correct, but
hopefully that won't come up in practice.