Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port all babel-parser changes from 2018-10-01 to 2018-11-09 #333

Merged
merged 1 commit into from Nov 12, 2018

Conversation

alangpierce
Copy link
Owner

Notably, this adds support for TypeScript 3.0 syntax.

Details:
07862e727 Fix perf issue in typescript parser plugin (#8792)
🚫 Already implemented with a similar fix.

3c8740171 [decorators] [typescript] Parse type parameters (#8767)
βœ… Straightforward port.

a5b5ed928 Typescript - Tuple elements can be optional (#8720)
βœ… Straightforward port.

2575312d1 Fix parsing of slash after class expression (#8804)
βœ… Already worked, added test.

850bc1d3d class private methods and properties: should not allow spaces between # and identifier (#8756)
🚫 Error checking only.

08454ece4 Typescript - Tuples can include rest elements (#8805)
βœ… Straightforward port.

d2c75c2d3 fix: corrects handling of newline after async with paren-less arrow function (#8830)
βœ… Straightforward port with new regression test.

ce1a6526e flow-bin@0.82.0 (#8832)
🚫 Nothing to port.

8ee857e26 v7.1.3
🚫 Nothing to port.

929567523 Fixes #8865 (#8866)
🚫 Sucrase doesn't maintain curLine.

e4929e11f [flow] Explicit inexact objects with ... (#8884)
βœ… Relatively straightforward port with test. No error handling ported.

cd81b079e Allow function types in type params within arrow return types (#8954)
βœ… Already worked, just implemented test.

f216a7b06 [flow] Add support for parsing _ as implicit instantiation in call/new (#8883)
βœ… Already worked, complexity in the babel code seemed to all be around error
handling.

24c4901ff Remove Babylon plugins for features already merged to the ECMAScript spec (#8448)
🚫 Sucrase doesn't have parser plugins.

e3b2c1aff fix: Do not allow TypeCastExpressions w/o parens (#8956)
🚫 Just extra error handling.

2194842d1 Typescript: Validate tuple type element positions (#8828)
🚫 Just error handling.

2fa198463 Fix await in function name and parameters (#7727)
🚫 Just error handling.

afe67a703 v7.1.5
🚫 Release only.

5d5cd8612 Fix several edge cases with context expression state (#8972)
βœ… Added tests, but seems like everything was already working. The fixes were
all around context, and Sucrase got rid of context.

343f776ca Rename primitive types to reserved types (#8984)
🚫 Code doesn't exist in Sucrase.

4f206b241 prettier@1.15.1 (#9001)
🚫 Tooling upgrade.

Notably, this adds support for TypeScript 3.0 syntax.

Details:
07862e727 Fix perf issue in typescript parser plugin (#8792)
🚫 Already implemented with a similar fix.

3c8740171 [decorators] [typescript] Parse type parameters (#8767)
βœ… Straightforward port.

a5b5ed928 Typescript - Tuple elements can be optional (#8720)
βœ… Straightforward port.

2575312d1 Fix parsing of slash after class expression (#8804)
βœ… Already worked, added test.

850bc1d3d class private methods and properties: should not allow spaces between # and identifier (#8756)
🚫 Error checking only.

08454ece4 Typescript - Tuples can include rest elements (#8805)
βœ… Straightforward port.

d2c75c2d3 fix: corrects handling of newline after async with paren-less arrow function (#8830)
βœ… Straightforward port with new regression test.

ce1a6526e flow-bin@0.82.0 (#8832)
🚫 Nothing to port.

8ee857e26 v7.1.3
🚫 Nothing to port.

929567523 Fixes #8865 (#8866)
🚫 Sucrase doesn't maintain curLine.

e4929e11f [flow] Explicit inexact objects with `...` (#8884)
βœ… Relatively straightforward port with test. No error handling ported.

cd81b079e Allow function types in type params within arrow return types (#8954)
βœ… Already worked, just implemented test.

f216a7b06 [flow] Add support for parsing `_` as implicit instantiation in call/new (#8883)
βœ… Already worked, complexity in the babel code seemed to all be around error
handling.

24c4901ff Remove Babylon plugins for features already merged to the ECMAScript spec (#8448)
🚫 Sucrase doesn't have parser plugins.

e3b2c1aff fix: Do not allow TypeCastExpressions w/o parens (#8956)
🚫 Just extra error handling.

2194842d1 Typescript: Validate tuple type element positions (#8828)
🚫 Just error handling.

2fa198463 Fix await in function name and parameters (#7727)
🚫 Just error handling.

afe67a703 v7.1.5
🚫 Release only.

5d5cd8612 Fix several edge cases with context expression state (#8972)
βœ… Added tests, but seems like everything was already working. The fixes were
all around context, and Sucrase got rid of context.

343f776ca Rename primitive types to reserved types (#8984)
🚫 Code doesn't exist in Sucrase.

4f206b241 prettier@1.15.1 (#9001)
🚫 Tooling upgrade.
@alangpierce alangpierce merged commit fadf8af into master Nov 12, 2018
@codecov-io
Copy link

Codecov Report

Merging #333 into master will increase coverage by 0.47%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   76.76%   77.24%   +0.47%     
==========================================
  Files          41       41              
  Lines        5281     5299      +18     
  Branches     1280     1286       +6     
==========================================
+ Hits         4054     4093      +39     
+ Misses        850      836      -14     
+ Partials      377      370       -7
Impacted Files Coverage Ξ”
src/parser/plugins/typescript.ts 71.1% <100%> (+1.52%) ⬆️
src/parser/traverser/expression.ts 78.92% <50%> (+1.62%) ⬆️
src/parser/plugins/flow.ts 60.81% <50%> (+0.88%) ⬆️
src/parser/traverser/statement.ts 80.98% <75%> (-0.05%) ⬇️
src/parser/tokenizer/readWord.ts 70.97% <0%> (+0.42%) ⬆️
src/parser/tokenizer/index.ts 73.77% <0%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 3032f6b...7724465. Read the comment docs.

@alangpierce alangpierce deleted the port-babel-parser-changes-october branch November 12, 2018 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants