Fix crash with TypeScript overloaded constructors #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #334 Constructors without bodies were correctly being marked as type tokens, but the class transformation code (to implement class fields and TS fields defined in constructor params) was incorrectly viewing it as a real constructor. Now, when checking if something matches the constructor keyword, we also make sure it's not a type token.
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
==========================================
+ Coverage 77.26% 77.26% +<.01%
==========================================
Files 41 41
Lines 5484 5485 +1
Branches 1288 1289 +1
==========================================
+ Hits 4237 4238 +1
Misses 878 878
Partials 369 369
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #334
Constructors without bodies were correctly being marked as type tokens, but the
class transformation code (to implement class fields and TS fields defined in
constructor params) was incorrectly viewing it as a real constructor. Now, when
checking if something matches the constructor keyword, we also make sure it's
not a type token.