Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite loop when a file ends with a short identifier #363

Merged
merged 1 commit into from Dec 1, 2018

Conversation

alangpierce
Copy link
Owner

We weren't properly checking for end-of-file when going through the readWord
tree.

We weren't properly checking for end-of-file when going through the readWord
tree.
@alangpierce alangpierce force-pushed the fix-identifier-eof-infinite-loop branch from a57ac7d to 10b0693 Compare December 1, 2018 20:27
@codecov-io
Copy link

Codecov Report

Merging #363 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #363      +/-   ##
=========================================
+ Coverage   79.24%   79.3%   +0.05%     
=========================================
  Files          44      44              
  Lines        4847    5068     +221     
  Branches     1133    1133              
=========================================
+ Hits         3841    4019     +178     
- Misses        706     747      +41     
- Partials      300     302       +2
Impacted Files Coverage Δ
src/parser/tokenizer/readWord.ts 85.36% <100%> (+3.54%) ⬆️
src/util/formatTokens.ts 70.58% <0%> (-10.06%) ⬇️
src/parser/util/identifier.ts 90.9% <0%> (-4.1%) ⬇️
src/parser/plugins/jsx/index.ts 87.33% <0%> (-1.88%) ⬇️
src/parser/plugins/flow.ts 62.14% <0%> (-1.59%) ⬇️
src/util/getClassInfo.ts 85.12% <0%> (-1.21%) ⬇️
src/parser/traverser/statement.ts 80.14% <0%> (-1.17%) ⬇️
src/util/isIdentifier.ts 100% <0%> (ø) ⬆️
src/parser/util/whitespace.ts 100% <0%> (ø) ⬆️
src/parser/traverser/index.ts 100% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bac8c6...10b0693. Read the comment docs.

@alangpierce alangpierce merged commit 1d54e95 into master Dec 1, 2018
@alangpierce alangpierce deleted the fix-identifier-eof-infinite-loop branch December 1, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants