Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow component names to start with _ #425

Merged
merged 1 commit into from Mar 1, 2019
Merged

Conversation

yang
Copy link
Contributor

@yang yang commented Feb 28, 2019

Fixes #424

Copy link
Owner

@alangpierce alangpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! One edge case that would be good to fix, but other than that looks good!

I can look into the test failures; they seem unrelated to your change.

src/transformers/JSXTransformer.ts Outdated Show resolved Hide resolved
@alangpierce
Copy link
Owner

@yang tests should be fixed now! Can you rebase? Also would be good to switch to the >= charCodes.lowercaseA && <= charCodes.lowercaseZ approach I mentioned, which also would likely be a little faster since it doesn't need to handle unicode.

@codecov-io
Copy link

codecov-io commented Feb 28, 2019

Codecov Report

Merging #425 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
- Coverage   80.09%   80.07%   -0.02%     
==========================================
  Files          47       47              
  Lines        5264     5040     -224     
  Branches     1174     1175       +1     
==========================================
- Hits         4216     4036     -180     
+ Misses        744      702      -42     
+ Partials      304      302       -2
Impacted Files Coverage Δ
src/transformers/JSXTransformer.ts 92.61% <100%> (+0.07%) ⬆️
src/parser/index.ts 77.77% <0%> (-7.94%) ⬇️
src/index.ts 82.85% <0%> (-6.51%) ⬇️
src/computeSourceMap.ts 83.33% <0%> (-5.56%) ⬇️
src/util/getNonTypeIdentifiers.ts 94.44% <0%> (-5.56%) ⬇️
src/util/getTSImportedNames.ts 81.57% <0%> (-3.79%) ⬇️
src/parser/plugins/types.ts 91.66% <0%> (-3.34%) ⬇️
src/parser/tokenizer/readWord.ts 82.35% <0%> (-3.02%) ⬇️
src/parser/traverser/util.ts 86.2% <0%> (-2.17%) ⬇️
src/parser/traverser/base.ts 95.45% <0%> (-1.69%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4593c51...c7f33cc. Read the comment docs.

Copy link
Owner

@alangpierce alangpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks!

@alangpierce alangpierce merged commit dcbe431 into alangpierce:master Mar 1, 2019
@alangpierce
Copy link
Owner

@yang Thanks, I just published as 3.9.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants