Allow super when using optional chaining #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progress toward #461 Tech plan: https://github.com/alangpierce/sucrase/wiki/Sucrase-Optional-Chaining-and-Nullish-Coalescing-Technical-Plan To allow super, we mostly just need to skip the code transform on the first subscript. We also need to add a `.bind(this)` when transforming the second subscript, which can be determined through a relatively straightforward token scan.
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
- Coverage 82.73% 82.68% -0.05%
==========================================
Files 55 55
Lines 5589 5608 +19
Branches 1253 1261 +8
==========================================
+ Hits 4624 4637 +13
- Misses 678 681 +3
- Partials 287 290 +3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress toward #461
Tech plan:
https://github.com/alangpierce/sucrase/wiki/Sucrase-Optional-Chaining-and-Nullish-Coalescing-Technical-Plan
To allow super, we mostly just need to skip the code transform on the first
subscript. We also need to add a
.bind(this)when transforming the secondsubscript, which can be determined through a relatively straightforward token
scan.