Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing path escaping to react-hot-loader #512

Merged
merged 3 commits into from Mar 16, 2020
Merged

Add missing path escaping to react-hot-loader #512

merged 3 commits into from Mar 16, 2020

Conversation

SkaceKamen
Copy link
Contributor

  • File path is escaped using JSON.stringify
  • Added regression test for this

Should fix #511

alangpierce
alangpierce approved these changes Mar 16, 2020
View reviewed changes
Copy link
Owner

@alangpierce alangpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alangpierce alangpierce merged commit ff49f4a into alangpierce:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alangpierce alangpierce alangpierce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react-hot-loader transform doesn't escape Windows paths
2 participants
@SkaceKamen @alangpierce