Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TS export elision for destructured variables #564

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Fix TS export elision for destructured variables #564

merged 1 commit into from
Dec 2, 2020

Commits on Dec 1, 2020

  1. Fix identifier role for top-level destructure declarations 

    Fixes #563
Fixes #473

The type-only export elision implemented in #433 had a false positive for
destructure delcarations, since `getDeclarationInfo` only looks at top-level
declarations and top-level expressions like `const {x} = ...` weren't being
marked correctly. To fix, we can mark object shorthand declarations as top-level
when applicable. I also refactored both relevant code paths to avoid the
repeated assignment left-hand side.
    @alangpierce
    alangpierce committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    636bf20 View commit details
    Browse the repository at this point in the history