Port babel-parser changes from 2021-02-18 to 2021-03-14 #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions: https://github.com/alangpierce/sucrase/wiki/Porting-changes-from-Babel's-parser 2f755ef052 v7.12.17 π« Release only. 16e9f1c8e5 Support Flow `this` parameter annotations (#12234) π« Seems to be working already. 5b99b8f221 Flow Enums with unknown members support (#12193) π« For now, Flow enums won't be supported in Sucrase. e4588bed22 Support TypeScript 4.2 abstract constructor signatures (#12628) β Ported with a similar implementation, but made a new enum value instead of passing a flag. 9c567baa9b Parse JS Module Blocks proposal (#12469) β Added basic parsing support, though the transformer doesn't yet do anything special. Filed #634 as follow-up. 03d7911be6 Implement class features in estree (#12370) π« Sucrase doesn't support entree. c827193d9c v7.13.0 π« Release only. c30039029a Don't enable class features by default in `estree` (#12867) π« Sucrase doesn't support entree. e940b8c4b9 v7.13.4 π« Release only. b62fc3d44f babel-parser(flow): Set `this` property to `null` for FunctionTypeAnnotation without parens (#12930) π« AST only. efdca01409 fix: add tokens when tokens: true is passed to parseExpression (#12939) π« Only applies to Babel-specific API. 2c0e8d0008 v7.13.9 π« Release only. b416847b61 (ts) Raise syntax error for abstract methods with a body (#12687) π« Validation only. d04842a700 Avoid using CJS globals in internal source files (#12963) π« Babel change not relevant for Sucrase. d1d404b9a3 v7.13.10 π« Release only. 1a05b81387 Support multiple static blocks (#12738) π« Only affects validation, multiple static blocks were already supported. 0988c471e9 Parse type imports in TSImportEqualsDeclaration (#12962) β Implemented independently using similar logic as in Babel.
Codecov Report
@@ Coverage Diff @@
## main #635 +/- ##
==========================================
+ Coverage 82.44% 82.54% +0.09%
==========================================
Files 56 56
Lines 5880 5684 -196
Branches 1327 1342 +15
==========================================
- Hits 4848 4692 -156
+ Misses 749 708 -41
- Partials 283 284 +1
Continue to review full report at Codecov.
|
Benchmark resultsBefore this PR: 306.6 thousand lines per second Measured change: 1.61% slower (3% slower to 0.32% faster) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions: https://github.com/alangpierce/sucrase/wiki/Porting-changes-from-Babel's-parser
2f755ef052 v7.12.17
π« Release only.
16e9f1c8e5 Support Flow
thisparameter annotations (#12234)π« Seems to be working already.
5b99b8f221 Flow Enums with unknown members support (#12193)
π« For now, Flow enums won't be supported in Sucrase.
e4588bed22 Support TypeScript 4.2 abstract constructor signatures (#12628)
β Ported with a similar implementation, but made a new enum value instead of passing a flag.
9c567baa9b Parse JS Module Blocks proposal (#12469)
β Added basic parsing support, though the transformer doesn't yet do anything special. Filed #634 as follow-up.
03d7911be6 Implement class features in estree (#12370)
π« Sucrase doesn't support estree.
c827193d9c v7.13.0
π« Release only.
c30039029a Don't enable class features by default in
estree(#12867)π« Sucrase doesn't support estree.
e940b8c4b9 v7.13.4
π« Release only.
b62fc3d44f babel-parser(flow): Set
thisproperty tonullfor FunctionTypeAnnotation without parens (#12930)π« AST only.
efdca01409 fix: add tokens when tokens: true is passed to parseExpression (#12939)
π« Only applies to Babel-specific API.
2c0e8d0008 v7.13.9
π« Release only.
b416847b61 (ts) Raise syntax error for abstract methods with a body (#12687)
π« Validation only.
d04842a700 Avoid using CJS globals in internal source files (#12963)
π« Babel change not relevant for Sucrase.
d1d404b9a3 v7.13.10
π« Release only.
1a05b81387 Support multiple static blocks (#12738)
π« Only affects validation, multiple static blocks were already supported.
0988c471e9 Parse type imports in TSImportEqualsDeclaration (#12962)
β Implemented independently using similar logic as in Babel.