Port babel-parser changes from 2021-03-15 to 2021-04-28 #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions: https://github.com/alangpierce/sucrase/wiki/Porting-changes-from-Babel's-parser 4b674ea031 v7.13.11 π« Release only. beb7cf8b24 Sort error keys with ESLint (#13020) π« Babel-internal change. edb11baabf v7.13.12 π« Release only. 4f727139ec fix(ts): Allow parenthesized "assert and assign" (#12933) π« Seems to work fine in Sucrase. 0067fd9e02 Disallow await before exponential (#12441) π« Validation only. 2f8203f190 v7.13.13 π« Release only. 8efbac4a5d fix: the LHS in for-of loop should not start with let (#13049) π« Validation only. a647b9ea6b Convert `@babel/core` to TypeScript (#12929) π« Babel-internal. 7fe3ebf4db fix: raise `SyntaxError` for unparenthesized assert and assign (#13099) π« Validation only. 42e630e8a2 Allow trailing comma after rest parameter in TSDeclareFunction (#13101) π« Seems to work fine in Sucrase. e50f6f7eef v7.13.15 π« Release only. 368bf893fa [ts] raise `SyntaxError` for `declare` before getter/setter (#13143) π« Validation only. d94a8e50ed v7.13.16 π« Release only. 10f4d08efb refactor: avoid parsing logic on locations (#13200) π« Refactor not relevant to Sucrase. 0ee98139a6 Introduce parser error codes (#13033) π« Error handling not relevant to Sucrase. eac0259ce2 Support TS 4.3 static index signature in classes (#13096) β Ported and updated parser to mark all modifiers as type tokens. f8aa32f767 Support parsing Flow's Indexed Access Types (#13053) β Straightforward port. bf14a106ad Support TS 4.3 `override` syntax in class (#13097) β Ported non-validation parts and implemented the feature in the transformer as well. 2521c666f7 Add internal ESLint rule for consistent parser error messages (#13130) π« Error messaging only. 7484b51e56 Support TS 4.3 `get`/`set` type members (#13089) β Ported, though the implementation needed some changes to avoid depending on the AST. c949660b34 babel-parser: Deep freeze for `makeErrorTemplates` (#13142) π« Babel internal.
Codecov Report
@@ Coverage Diff @@
## main #636 +/- ##
==========================================
+ Coverage 82.54% 82.57% +0.02%
==========================================
Files 56 56
Lines 5684 5686 +2
Branches 1342 1342
==========================================
+ Hits 4692 4695 +3
Misses 708 708
+ Partials 284 283 -1
Continue to review full report at Codecov.
|
Benchmark resultsBefore this PR: 285.7 thousand lines per second Measured change: 3.05% faster (2.79% faster to 4.56% faster) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions: https://github.com/alangpierce/sucrase/wiki/Porting-changes-from-Babel's-parser
4b674ea031 v7.13.11
π« Release only.
beb7cf8b24 Sort error keys with ESLint (#13020)
π« Babel-internal change.
edb11baabf v7.13.12
π« Release only.
4f727139ec fix(ts): Allow parenthesized "assert and assign" (#12933)
π« Seems to work fine in Sucrase.
0067fd9e02 Disallow await before exponential (#12441)
π« Validation only.
2f8203f190 v7.13.13
π« Release only.
8efbac4a5d fix: the LHS in for-of loop should not start with let (#13049)
π« Validation only.
a647b9ea6b Convert
@babel/coreto TypeScript (#12929)π« Babel-internal.
7fe3ebf4db fix: raise
SyntaxErrorfor unparenthesized assert and assign (#13099)π« Validation only.
42e630e8a2 Allow trailing comma after rest parameter in TSDeclareFunction (#13101)
π« Seems to work fine in Sucrase.
e50f6f7eef v7.13.15
π« Release only.
368bf893fa [ts] raise
SyntaxErrorfordeclarebefore getter/setter (#13143)π« Validation only.
d94a8e50ed v7.13.16
π« Release only.
10f4d08efb refactor: avoid parsing logic on locations (#13200)
π« Refactor not relevant to Sucrase.
0ee98139a6 Introduce parser error codes (#13033)
π« Error handling not relevant to Sucrase.
eac0259ce2 Support TS 4.3 static index signature in classes (#13096)
β Ported and updated parser to mark all modifiers as type tokens.
f8aa32f767 Support parsing Flow's Indexed Access Types (#13053)
β Straightforward port.
bf14a106ad Support TS 4.3
overridesyntax in class (#13097)β Ported non-validation parts and implemented the feature in the transformer as well.
2521c666f7 Add internal ESLint rule for consistent parser error messages (#13130)
π« Error messaging only.
7484b51e56 Support TS 4.3
get/settype members (#13089)β Ported, though the implementation needed some changes to avoid depending on the AST.
c949660b34 babel-parser: Deep freeze for
makeErrorTemplates(#13142)π« Babel internal.