Port babel-parser changes from 2021-04-28 to 2021-07-02 #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions: https://github.com/alangpierce/sucrase/wiki/Porting-changes-from-Babel's-parser b116865077 Use this.isThisParam in typescript parser (#13163) π« Refactor not directly relevant to Sucrase. ceaab0bae7 Parse class fields and private methods by default (#13175) π« Sucrase doesn't gate ES features. 57daba85aa Parse string export names by default (`moduleStringNames`) (#13195) π« Sucrase doesn't gate ES features. 8433cd0c05 Support parsing Flow's Optional Indexed Access Types (#13224) β Straightforward port, didn't seem to need the lexer change. 22b0eb038f [ts] Enforce order for the `override` modifier (#13209) π« TS only. 7f5b212322 babel-parser: Add new `typescript` plugin option `dts: boolean` (#13113) π« Only affects error handling. 28d7442aae Parse async do expressions (#13043) β Ported in a similar way. a2ac2f39b5 Update `@babel/parser` fixtures π« Tests only. 0f2a1a8153 Add `runFixtureTestsWithoutExactASTMatch` in parser test runner (#13227) π« Only affects test infra. 3c0152a217 v7.14.0 π« Release only. 2a3e35f026 chore: remove duplicate test262 parser tests (#13241) π« Only affects tests. fa01fbe052 Parse `for await (async of ...)` (#13244) π« This feels like unreasonable enough code and enough parser complexity that it feels probably fine to not support in Sucrase, at least for now. 175a51f94e Don't use `"composite": true` in tsc (until it supports cycles) (#13242) π« Babel-internal. ef87648f3f Parse static blocks with typescript plugin (#13243) π« Seems to be working fine from my testing. 3ecc7919c5 v7.14.1 π« Release only. 278193b6f7 fix: update chunkStart on missing unicode escape (#13261) π« Code not relevant to Sucrase. a387973821 Refactor private name tokenizing (#13256) π« I'll skip the refactor for now, the benefits don't currently seem compelling. a8fea4037d Faster identifier tokenizing (#13262) π« I'll skip the refactor for now, the benefits don't currently seem compelling. 1d54419ec4 Parse attributes of import expression with estree plugin (#13284) π« Sucrase doesn't support estree. b2d9156cc6 Update to Prettier 2.3 (#13288) π« Babel-internal. 7512095c84 v7.14.2 π« Release only. b3d35cd412 [Babel 8]: remove module attributes parser/generator support (#13308) π« Wasn't in Sucrase in the first place. c2181343f1 Parse `let` declarations whose id starts with `\` (#13325) π« Bug doesn't affect Sucrase. 0d0950f341 fix: preserve tokensLength in tryParse (#13326) π« Only affects recovery mode. 1487a46dd5 v7.14.3 π« Release only. 2a5b23186a perf: minimize identifier lookahead when parsing let (#13328) π« Sucrase doesn't special-case the let keyword. 461ba2531a refactor: add parse*Literal parser routines (#13333) π« Benefits don't seem relevant for Sucrase. d6a5f6190d [ts] Default `typeAnnotation` of `TSTypePredicate` to `null` (#13354) π« AST only. acf2a10899 Faster tokenizer lookahead (#13341) π« Doesn't seem worth porting for now, unclear if it really applies as-is in Sucrase. 079f8cd5bc fix: disallow surrogate in the end of contextual name (#13377) π« Code not relevant for Sucrase. 1341e560ff Skip `flow/typecasts/3` test on Node.js 6 (#13382) π« Babel-internal. 219fd3ab1f v7.14.4 π« Release only. 0b29b5c2c0 Add support for d flag of regex literals in parser (#13396) π« Already works in Sucrase. 140ec5aa5c chore: setup Yarn constraints (#13363) π« Babel-internal. ae3f5d905a Back parser state `exportedIdentifiers` by set (#13406) π« Not relevant to Sucrase. cbad50ac1d Faster checkReservedWord (#13386) π« Sucrase does reserved word checking using readWordTree, which is likely faster. b281fe352c Use set in parser scope (#13408) π« Code path not relevant to Sucrase. b8175ec060 Relax import assertion key-is-type constraint (#13409) π« Validation only. a0369fdbfa fix: throw when `async()` call param is object with assignement (#13410) π« Validation only. 56db172b0e fix(`@babel/parser`): fix tokenizer context update code (#13422) π« Code not relevant to Sucrase. a64d08c101 fix(parser): correctly parse record and tuple tokens (#13418) π« Holding off on an implementation for now. b9c1884a58 Reduce `exprAllowed` usage (#13431) π« This tokenizer code no longer exists in Sucrase. d3f4c22c28 update test fixtures (#13440) π« Babel-internal. 7a2a928398 v7.14.5 π« Release only. b1fe831e4a fix: disallow JSX tag after non-null assertion (#13449) π« Bug doesn't appear to come up in Sucrase. 0eb2853732 [ts] Support override modifiers for parameter properties (#13428) β Ported basic change by allowing override in that position. 6c8b2336f6 Faster readRegexp (#13453) π« Many of the optimizations have been applied already. 1774e2aaef v7.14.6 π« Release only. 101249f3aa refactor(parser): remove refNeedsArrowPos (#13419) π« Already removed from Sucrase. 5145c98a73 Simplify token context (#13450) π« Sucrase already removed token context. 268e4ca0de v7.14.7 π« Release only. b0fe6bdbc3 chore(parser): add test to handle optional paramteter in async call (#13504) π« Test only. e6068cd9a5 enhance benchmark output with thousands separators (#13512) π« Babel-internal. 9bad558d13 [babel 8] Use an identifier for `TSTypeParameter.name` (#12829) π« AST-only.
Codecov Report
@@ Coverage Diff @@
## main #637 +/- ##
=======================================
Coverage 82.57% 82.58%
=======================================
Files 56 56
Lines 5686 5689 +3
Branches 1342 1343 +1
=======================================
+ Hits 4695 4698 +3
Misses 708 708
Partials 283 283
Continue to review full report at Codecov.
|
Benchmark resultsBefore this PR: 300 thousand lines per second Measured change: 0.56% slower (2.9% slower to 0% faster) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions: https://github.com/alangpierce/sucrase/wiki/Porting-changes-from-Babel's-parser
b116865077 Use this.isThisParam in typescript parser (#13163)
π« Refactor not directly relevant to Sucrase.
ceaab0bae7 Parse class fields and private methods by default (#13175)
π« Sucrase doesn't gate ES features.
57daba85aa Parse string export names by default (
moduleStringNames) (#13195)π« Sucrase doesn't gate ES features.
8433cd0c05 Support parsing Flow's Optional Indexed Access Types (#13224)
β Straightforward port, didn't seem to need the lexer change.
22b0eb038f [ts] Enforce order for the
overridemodifier (#13209)π« TS only.
7f5b212322 babel-parser: Add new
typescriptplugin optiondts: boolean(#13113)π« Only affects error handling.
28d7442aae Parse async do expressions (#13043)
β Ported in a similar way.
a2ac2f39b5 Update
@babel/parserfixturesπ« Tests only.
0f2a1a8153 Add
runFixtureTestsWithoutExactASTMatchin parser test runner (#13227)π« Only affects test infra.
3c0152a217 v7.14.0
π« Release only.
2a3e35f026 chore: remove duplicate test262 parser tests (#13241)
π« Only affects tests.
fa01fbe052 Parse
for await (async of ...)(#13244)π« This feels like unreasonable enough code and enough parser complexity that it feels probably fine to not support in Sucrase, at least for now.
175a51f94e Don't use
"composite": truein tsc (until it supports cycles) (#13242)π« Babel-internal.
ef87648f3f Parse static blocks with typescript plugin (#13243)
π« Seems to be working fine from my testing.
3ecc7919c5 v7.14.1
π« Release only.
278193b6f7 fix: update chunkStart on missing unicode escape (#13261)
π« Code not relevant to Sucrase.
a387973821 Refactor private name tokenizing (#13256)
π« I'll skip the refactor for now, the benefits don't currently seem compelling.
a8fea4037d Faster identifier tokenizing (#13262)
π« I'll skip the refactor for now, the benefits don't currently seem compelling.
1d54419ec4 Parse attributes of import expression with estree plugin (#13284)
π« Sucrase doesn't support estree.
b2d9156cc6 Update to Prettier 2.3 (#13288)
π« Babel-internal.
7512095c84 v7.14.2
π« Release only.
b3d35cd412 [Babel 8]: remove module attributes parser/generator support (#13308)
π« Wasn't in Sucrase in the first place.
c2181343f1 Parse
letdeclarations whose id starts with\(#13325)π« Bug doesn't affect Sucrase.
0d0950f341 fix: preserve tokensLength in tryParse (#13326)
π« Only affects recovery mode.
1487a46dd5 v7.14.3
π« Release only.
2a5b23186a perf: minimize identifier lookahead when parsing let (#13328)
π« Sucrase doesn't special-case the let keyword.
461ba2531a refactor: add parse*Literal parser routines (#13333)
π« Benefits don't seem relevant for Sucrase.
d6a5f6190d [ts] Default
typeAnnotationofTSTypePredicatetonull(#13354)π« AST only.
acf2a10899 Faster tokenizer lookahead (#13341)
π« Doesn't seem worth porting for now, unclear if it really applies as-is in Sucrase.
079f8cd5bc fix: disallow surrogate in the end of contextual name (#13377)
π« Code not relevant for Sucrase.
1341e560ff Skip
flow/typecasts/3test on Node.js 6 (#13382)π« Babel-internal.
219fd3ab1f v7.14.4
π« Release only.
0b29b5c2c0 Add support for d flag of regex literals in parser (#13396)
π« Already works in Sucrase.
140ec5aa5c chore: setup Yarn constraints (#13363)
π« Babel-internal.
ae3f5d905a Back parser state
exportedIdentifiersby set (#13406)π« Not relevant to Sucrase.
cbad50ac1d Faster checkReservedWord (#13386)
π« Sucrase does reserved word checking using readWordTree, which is likely faster.
b281fe352c Use set in parser scope (#13408)
π« Code path not relevant to Sucrase.
b8175ec060 Relax import assertion key-is-type constraint (#13409)
π« Validation only.
a0369fdbfa fix: throw when
async()call param is object with assignement (#13410)π« Validation only.
56db172b0e fix(
@babel/parser): fix tokenizer context update code (#13422)π« Code not relevant to Sucrase.
a64d08c101 fix(parser): correctly parse record and tuple tokens (#13418)
π« Holding off on an implementation for now.
b9c1884a58 Reduce
exprAllowedusage (#13431)π« This tokenizer code no longer exists in Sucrase.
d3f4c22c28 update test fixtures (#13440)
π« Babel-internal.
7a2a928398 v7.14.5
π« Release only.
b1fe831e4a fix: disallow JSX tag after non-null assertion (#13449)
π« Bug doesn't appear to come up in Sucrase.
0eb2853732 [ts] Support override modifiers for parameter properties (#13428)
β Ported basic change by allowing override in that position.
6c8b2336f6 Faster readRegexp (#13453)
π« Many of the optimizations have been applied already.
1774e2aaef v7.14.6
π« Release only.
101249f3aa refactor(parser): remove refNeedsArrowPos (#13419)
π« Already removed from Sucrase.
5145c98a73 Simplify token context (#13450)
π« Sucrase already removed token context.
268e4ca0de v7.14.7
π« Release only.
b0fe6bdbc3 chore(parser): add test to handle optional paramteter in async call (#13504)
π« Test only.
e6068cd9a5 enhance benchmark output with thousands separators (#13512)
π« Babel-internal.
9bad558d13 [babel 8] Use an identifier for
TSTypeParameter.name(#12829)π« AST-only.