Properly remove ! from definite assignment assertions
#658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #639 Previously, the `!` operator for class field declarations was not treated as a type token, so it wasn't automatically removed at transpile. In most cases, this wasn't relevant because the class field transform removes uninitialized fields completely. However, there are two cases where it causes an issue: * `disableESTransforms: true`, which disables the class field transform. * Private fields, which are skipped by the class field transform. In both cases, we can fix the issue by just setting the `!` as a type token so that it will naturally get removed by the TS transformer. I also did a little refactoring to pull out the logic for handling individual type tokens.
Codecov Report
@@ Coverage Diff @@
## main #658 +/- ##
==========================================
+ Coverage 82.58% 82.67% +0.08%
==========================================
Files 56 56
Lines 5690 5932 +242
Branches 1344 1343 -1
==========================================
+ Hits 4699 4904 +205
- Misses 708 745 +37
Partials 283 283
Continue to review full report at Codecov.
|
Benchmark resultsBefore this PR: 330.3 thousand lines per second Measured change: 0.27% slower (0.96% slower to 0.18% faster) |
alangpierce
deleted the
fix-class-field-definite-assignment-assertions
branch
|
Published as 3.20.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #639
Previously, the
!operator for class field declarations was not treated as atype token, so it wasn't automatically removed at transpile. In most cases, this
wasn't relevant because the class field transform removes uninitialized fields
completely. However, there are two cases where it causes an issue:
disableESTransforms: true, which disables the class field transform.In both cases, we can fix the issue by just setting the
!as a type token sothat it will naturally get removed by the TS transformer.
I also did a little refactoring to pull out the logic for handling individual
type tokens.