Fix parse failures when using ?? just after the end of a type #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was detected when running Sucrase on the Babel test suite.
Codecov Report
@@ Coverage Diff @@
## main #721 +/- ##
=======================================
Coverage 87.03% 87.03%
=======================================
Files 54 54
Lines 5700 5702 +2
Branches 1341 1343 +2
=======================================
+ Hits 4961 4963 +2
Misses 470 470
Partials 269 269
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Benchmark resultsBefore this PR: 258.7 thousand lines per second Measured change: 0.39% faster (0.16% slower to 1.54% faster) |
The conditional tokenization is only necessary for Flow and only causes issuse in TypeScript, so separating the cases out fixes this issue in a more fundamental way.
1Lighty
pushed a commit
to Astra-mod/sucrase
that referenced
this pull request
Aug 14, 2022
…ierce#721) This was detected when running Sucrase on the Babel test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was detected when running Sucrase on the Babel test suite.