Port babel-parser changes from 2022-10-26 to 2022-12-22 #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions: https://github.com/alangpierce/sucrase/wiki/Porting-changes-from-Babel's-parser dfc4b61856 Parse import reflection (#14926) ✅ Implemented a basic version with tests, without any attempt at CJS support or type import support since the behavior appears unspecified at this point. 83009601f4 Parse `using` declaration (explicit resource management) (#14968) ✅ Implemented in a similar way with some simplifications since error handling isn't necessary. 04509a3be6 v7.20.0 🚫 Release only. 292e5d6b67 fix: parse `a satisfies b` as left value (#15096) ✅ Already worked, but added a test. 283720d252 fix: Parse re-declare var in class static body (#15102) 🚫 Error handling bug that didn't affect Sucrase. cfc453276a Fix(estree): Reset export's start after decorator (#15107) 🚫 estree not relevant to Sucrase. 1893249b67 v7.20.1 🚫 Release only. b5a6931c23 fix: `parser` typings for plugins (#15094) 🚫 Babel-internal change. 12a58cb58c v7.20.2 🚫 Release only. ce09a269d8 fix: support await as for-of-lhs (#15134) 🚫 Sucrase assumes modules, and `await` is a reserved word in modules. 7c9a8015fe v7.20.3 🚫 Release only. 5fde28b37e fix: Babel 8 types (#15109) 🚫 Babel-internal change. 4dedd57f64 fix: parse `import module, ...` (#15198) ✅ Fixed in implementation above. f6546d79d4 Bump typescript to 4.9.3 (#15202) 🚫 Babel-internal change. 4c59d9fb2c Export `ParseResult` type (#15207) 🚫 Babel-internal change. 4369b33100 Parse `using[foo]` as computed member expression (#15225) ✅ Fixed with a simpler lookahead approach. 29a97b8ea2 v7.20.5 🚫 Release only. f543b61bab refactor: remove ModuleDeclaration usage (#15236) 🚫 AST only. 362451b764 chore: Enable eslint rule `no-unnecessary-type-assertion` (#15260) 🚫 Babel-internal change. 1203f1858d chore: Clean up `parser` comments (#15252) 🚫 Babel-internal change. 3a71c79a56 fix: Support auto accessors with TypeScript annotations (#15209) ✅ This was already working in Sucrase, but added a test. d414940e4c v7.20.7 🚫 Release only.
Codecov Report
@@ Coverage Diff @@
## main #785 +/- ##
==========================================
+ Coverage 87.61% 88.14% +0.52%
==========================================
Files 55 55
Lines 5888 5915 +27
Branches 1395 1404 +9
==========================================
+ Hits 5159 5214 +55
+ Misses 461 434 -27
+ Partials 268 267 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark resultsBefore this PR: 390.1 thousand lines per second Measured change: 0.08% slower (1.19% slower to 0% slower) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions: https://github.com/alangpierce/sucrase/wiki/Porting-changes-from-Babel's-parser
dfc4b61856 Parse import reflection (#14926)
✅ Implemented a basic version with tests, without any attempt at CJS support or type import support since the behavior appears unspecified at this point.
83009601f4 Parse
usingdeclaration (explicit resource management) (#14968)✅ Implemented in a similar way with some simplifications since error handling isn't necessary.
04509a3be6 v7.20.0
🚫 Release only.
292e5d6b67 fix: parse
a satisfies bas left value (#15096)✅ Already worked, but added a test.
283720d252 fix: Parse re-declare var in class static body (#15102)
🚫 Error handling bug that didn't affect Sucrase.
cfc453276a Fix(estree): Reset export's start after decorator (#15107)
🚫 estree not relevant to Sucrase.
1893249b67 v7.20.1
🚫 Release only.
b5a6931c23 fix:
parsertypings for plugins (#15094)🚫 Babel-internal change.
12a58cb58c v7.20.2
🚫 Release only.
ce09a269d8 fix: support await as for-of-lhs (#15134)
🚫 Sucrase assumes modules, and
awaitis a reserved word in modules.7c9a8015fe v7.20.3
🚫 Release only.
5fde28b37e fix: Babel 8 types (#15109)
🚫 Babel-internal change.
4dedd57f64 fix: parse
import module, ...(#15198)✅ Fixed in implementation above.
f6546d79d4 Bump typescript to 4.9.3 (#15202)
🚫 Babel-internal change.
4c59d9fb2c Export
ParseResulttype (#15207)🚫 Babel-internal change.
4369b33100 Parse
using[foo]as computed member expression (#15225)✅ Fixed with a simpler lookahead approach.
29a97b8ea2 v7.20.5
🚫 Release only.
f543b61bab refactor: remove ModuleDeclaration usage (#15236)
🚫 AST only.
362451b764 chore: Enable eslint rule
no-unnecessary-type-assertion(#15260)🚫 Babel-internal change.
1203f1858d chore: Clean up
parsercomments (#15252)🚫 Babel-internal change.
3a71c79a56 fix: Support auto accessors with TypeScript annotations (#15209)
✅ This was already working in Sucrase, but added a test.
d414940e4c v7.20.7
🚫 Release only.