Fix dynamic import on plain CJS files #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #778 Previously, `import()` transpiled to a promise-wrapped `require`, which worked fine for ESM-to-CJS-transpiled modules, but when importing plain CJS modules, the behavior was inconsistent with other implementations. In that case, we needed to call `_interopRequireWildcard` to nest the module under a `default` key. I tested to confirm that this updated behavior is consistent with Node ESM-to-CJS dynamic import, as well as Babel, TypeScript, and swc, so this change will be considered a bug fix rather than a breaking change, even though it is possible that existing use cases may have been relying on the old behavior.
Codecov Report
@@ Coverage Diff @@
## main #789 +/- ##
=======================================
Coverage 88.32% 88.32%
=======================================
Files 55 55
Lines 5954 5955 +1
Branches 1413 1413
=======================================
+ Hits 5259 5260 +1
Misses 430 430
Partials 265 265
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Benchmark resultsBefore this PR: 308 thousand lines per second Measured change: 2.34% slower (3.93% slower to 0.07% faster) |
alangpierce
added a commit
that referenced
this pull request
Mar 27, 2023
In #789, I changed dynamic `import()` to use `_interopRequireWildcard`. However, after some more testing, I realized that `enableLegacyTypeScriptModuleInterop` mode should *not* do this, since it's an older interpretation of interop that generally doesn't use these helpers. This PR adds that as a new special case.
alangpierce
added a commit
that referenced
this pull request
Mar 27, 2023
In #789, I changed dynamic `import()` to use `_interopRequireWildcard`. However, after some more testing, I realized that `enableLegacyTypeScriptModuleInterop` mode should *not* do this, since it's an older interpretation of interop that generally doesn't use these helpers. This PR adds that as a new special case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #778
Previously,
import()transpiled to a promise-wrappedrequire, which worked fine for ESM-to-CJS-transpiled modules, but when importing plain CJS modules, the behavior was inconsistent with other implementations. In that case, we needed to call_interopRequireWildcardto nest the module under adefaultkey.I tested to confirm that this updated behavior is consistent with Node ESM-to-CJS dynamic import, as well as Babel, TypeScript, and swc, so this change will be considered a bug fix rather than a breaking change, even though it is possible that existing use cases may have been relying on the old behavior.