Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove constructor return type annotations #800

Merged
merged 1 commit into from Jun 29, 2023

Conversation

alangpierce
Copy link
Owner

Fixes #795

This syntax isn't actually valid, but it's easy enough to product working JS to avoid blocking the developer, so this implements that.

Fixes #795

This syntax isn't actually valid, but it's easy enough to product working JS to
avoid blocking the developer, so this implements that.
@github-actions
Copy link

Benchmark results

Before this PR: 402.9 thousand lines per second
After this PR: 403.2 thousand lines per second

Measured change: 0.06% faster (0.84% slower to 0.52% faster)
Summary: Likely no significant difference

@alangpierce alangpierce merged commit 6f983ef into main Jun 29, 2023
6 checks passed
@alangpierce alangpierce deleted the remove-constructor-return-type-annotations branch June 29, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constructor return type annotations produce invalid JS syntax
1 participant