Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shadowed global detection to ignore declarations in type tokens #809

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix shadowed global detection to ignore declarations in type tokens #809

merged 1 commit into from
Jul 13, 2023

Commits on Jul 12, 2023

  1. Fix shadowed global detection to ignore declarations in type tokens 

    Fixes #808

All identifier tokens, including type tokens, have a role assigned by the parser
that indicates whether they're a declaration, usage, etc, and even for type
tokens this is important for TS automatic export elision. When identifying
shadowed globals, though, only non-type declarations should be considered. This
fixes an issue where parameters within TS function types were inadvertently
being treated as declarations.
    @alangpierce
    alangpierce committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    82ac6a8 View commit details
    Browse the repository at this point in the history