Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning for invalid packages #54

Closed
wants to merge 6 commits into from
Closed

Show warning for invalid packages #54

wants to merge 6 commits into from

Conversation

dazhaoniel
Copy link

@dazhaoniel dazhaoniel commented May 19, 2023

Add warning for non existent packages, with output in terminal Could not find a version that satisfies the requirement non-existent-package (from -r req.txt (line 1)) (from versions: none).

Screenshot 2023-05-18 at 11 44 16 PM

Address issue #36

pur/__init__.py Outdated
package=req.name,
version=latest_ver
)
if echo and not dry_run:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we show the warning also in dry runs --dry?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I'll add that

@alanhamlett
Copy link
Owner

Implemented with e11bae6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants