Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Command Find Not Parsing --retrieve Option #6

Closed
greaterweb opened this issue Mar 25, 2016 · 0 comments
Closed

CLI Command Find Not Parsing --retrieve Option #6

greaterweb opened this issue Mar 25, 2016 · 0 comments

Comments

@greaterweb
Copy link
Contributor

The --retrieve option is not being parsed correctly.

$ portastic find 3000 3100 -r 1
Unhandled rejection Error: listen EACCES 0.0.0.0:1
    at Object.exports._errnoException (util.js:870:11)
    at exports._exceptionWithHostPort (util.js:893:20)
    at Server._listen2 (net.js:1224:19)
    at listen (net.js:1273:10)
    at net.js:1382:9
    at nextTickCallbackWith3Args (node.js:452:9)
    at process._tickCallback (node.js:358:17)
Unhandled rejection Error: listen EACCES 0.0.0.0:1
    at Object.exports._errnoException (util.js:870:11)
    at exports._exceptionWithHostPort (util.js:893:20)
    at Server._listen2 (net.js:1224:19)
    at listen (net.js:1273:10)
    at net.js:1382:9
    at nextTickCallbackWith3Args (node.js:452:9)
    at process._tickCallback (node.js:358:17)

The type appears to be missing in the option declaration which looks to be the problem. I'll create a PR to address the issue.

Related, the --retrieve option for find could probably stand to have some documentation to go along with it. I saw the API had the option available and only realized the CLI did as well when taking a look at the source. It looks like this might be a limitation of the commander library when options are defined for commands.

In any case, good work on the lib, it was exactly what I was looking for ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant