New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not leak HTTPS cookies to HTTP or JS #35

Merged

alanhogan merged 1 commit into master from ajh/secure-cookies

Sep 16, 2017

Owner

alanhogan commented Sep 16, 2017 •

edited

Loading

This change does two things

Prevents admins running their site on HTTPS from leaking cookies over HTTP
Prevents JavaScript from being able to inspect the cookie value

We should encourage people to change their passwords after this (hopefully alongside fixes for #33, #34)


          Do not leak HTTPS cooies to HTTP

f967a19

alanhogan added the Security label

alanhogan merged commit 215a166 into master

alanhogan deleted the ajh/secure-cookies branch

September 16, 2017 05:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment