Remove regression from subset-cols

src/panthera/pandas/generics.clj

@@ -597,7 +597,11 @@
   (py/call-attr df-or-srs "head" (or n 5)))
 
 (defn subset-cols
-  "Select columns by name
+  "Select columns by name.
+
+  Note that `colnames` are treated as literals: there's no
+  conversion involved, so if you pass a keyword it gets
+  translated as a string exactly as it is.
 
   **Arguments**
 
@@ -622,8 +626,7 @@
   ;2  6  8
   ```"
   [df & colnames]
-  (let [cols (u/vec->pylist (map u/memo-key-converter colnames))]
-    (py/get-item df cols)))
+  (py/get-item df colnames))
 
 (defn n-largest
   "Return the first `:n` values ordered by `:columns` in descending order.

test/panthera/generics_test.clj

@@ -174,7 +174,6 @@
             (g/data-frame i)
             cols))
           o)
-    [] nil []
     [{:a 1}] [:a] [{:a 1}]
     [{:a 1 :b 2 :c 3}] [:a :c] [{:a 1 :c 3}]
     (repeat 5 {:a 1 :b 2}) [:b] (repeat 5 {:b 2})
@@ -272,7 +271,7 @@
       (= (vec (g/names (g/data-frame i))) o)
     [{:a 1 :b 2}] ["a" "b"]
     [{"a name" 1 :c 2}] ["a name" "c"]
-    [{123 1 1/5 3}] [0.2 123.0]))
+    [{123 1 1/5 3}] [123.0 0.2]))
 
 (deftest filter-rows
   (are [i b o]
@@ -287,8 +286,10 @@
 
     (g/data-frame [{:a 1 :b 2}
                    {:a 3 :b 4}])
-    #(-> (g/subset-cols % :a)
-         (m/lt 3))
+    #(-> %
+         (g/subset-cols :a)
+         (m/lt 3)
+         g/values)
     [{:a 1 :b 2}]
 
     (g/data-frame [{:a 1 :b 2}