MetadataMode - bep52 #663
Merged
MetadataMode - bep52 #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A long time ago I made an assumption that, like elsewhere in the spec, the final request for piecehashes would be truncated if it extended beyond the end of the hashes. How wrong I was. After validating against libtorrent 2.x (using qbittorrent) I confirmed this doens't happen, and fixed up the impl to no longer truncate the last message, but to full it with padding hashes instead. The internal datastructure is still sparse though - it doesn't create a buffer to hold all the padding hashes.
If no file is logner than 1 piece, then we don't need any piece hashes, and can create the 'HashesV2' object immediately. The file can be fully validated using just the root hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed several bugs around requesting piece hashes for BEP52 torrents. Such as: