New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n #1
base: master
Are you sure you want to change the base?
Conversation
Varias cosas para remarcar:
|
src/tanks.js
Outdated
@@ -1,6 +1,7 @@ | |||
import Unit from './classes/unit'; | |||
import Tank from './classes/tank'; | |||
import Interface from './classes/interface'; | |||
import i18n from "i18n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si en todos lados estan usando single quote deberias usar single quote, no double quote.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opté por remover ese import, ya no era necesario porque es importado en index.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
genial
index.js
Outdated
i18n = require('i18n'); | ||
|
||
i18n.configure({ | ||
directory: __dirname + '/locales' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¿Esto funciona en windows? o habría que por las dudas usar
path.join
o similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lo cambié por por path.join(__dirname, '/locales')
que nos saca el problema de los slashes según sistema operativo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfecto
@josx No te esta funcionando porque no están las cosas buildeadas como originalmente vienen en el repo, en un principio no lo subí por una cuestión de que no es buena practica pero si es cierto que sin eso y siguiendo las instrucciones del README no funcionaría si lo descargan. En cuanto a lo de los multiples commits desde la pull puedo hacer un "Squash and merge" que junta todos los commits y mergea, es esa la idea o debería encararlo de otro modo? |
|
22077d9
to
4c9abab
Compare
Implemented node-i18n and added es/en locales