fix: esbuild warning about ?? operator in lte-reader #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restores the [pre-typescript](https://github.com/alanshaw/it-tar/blob/f6e492a44070816c4989af89e1602e656a27ecd4/lte-reader.js#L20) behaviour of `lte-reader` to just checking that the `done` value is true. Adds tests to prevent regressions. Closes #67
achingbrain
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 92.07% 92.08% +0.01%
==========================================
Files 10 11 +1
Lines 1917 1946 +29
Branches 303 307 +4
==========================================
+ Hits 1765 1792 +27
- Misses 152 154 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 22, 2024
## [6.0.5](v6.0.4...v6.0.5) (2024-02-22) ### Bug Fixes * esbuild warning about ?? operator in lte-reader ([#71](#71)) ([e12843f](e12843f)), closes [/github.com/alanshaw/it-tar/blob/f6e492a44070816c4989af89e1602e656a27ecd4/lte-reader.js#L20](https://github.com/alanshaw//github.com/alanshaw/it-tar/blob/f6e492a44070816c4989af89e1602e656a27ecd4/lte-reader.js/issues/L20) [#67](#67)
|
🎉 This PR is included in version 6.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores the pre-typescript behaviour of
lte-readerto just checking that thedonevalue is true.Adds tests to prevent regressions.
Closes #67