Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cwd option or similar #21

Closed
jugglinmike opened this issue Feb 14, 2014 · 2 comments
Closed

cwd option or similar #21

jugglinmike opened this issue Feb 14, 2014 · 2 comments

Comments

@jugglinmike
Copy link

Currently, images are interpreted relative to this project's html5bp/ directory. This makes it difficult to include image assets inline. With a cwd option, the consumer code could set the relative location from which to interpret the generated HTML document. This feature would also simplify the cssPath option (where users currently have to specify a path in terms of this module's html5bp/ directory).

I'm thinking this could be implemented using PhantomJS's setContent method, which allows for setting the page content and URL separately. In this case, the HTML5 Boilerplate's index.html file would have to be made into a template so that the resources it references could be loaded independently of the user-specified cwd.

Does the feature make sense? How about the proposed implementation?

@alanshaw
Copy link
Owner

YES. That's a great plan. Maybe name it something different because this could get confusing with the output path used by the CLI. A PR would be gratefully accepted.

@borisovg
Copy link

Random user feedback: this issue was a show-stopper when I tried using this module. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants