Fixed problem where clients could not connect in PASV mode. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for overriding the default initial CWD via 'options' object's
getInitialCwd attribute, which expects a function with signature
'function(username) { ... }'.
The function is expected to return the initial CWD path.
ghost
closed this
How about using the IP address of the interface that the client connected through? For a multi-homed server connected to several LANs, the "first" approach will guess correctly for at most one LAN, if any. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello alanszlosek,
Thanks for implementing this library! =)
I found that there was a problem with clients connecting in PASV mode, due to a missing
hostvariable.I have added the fix to get the first available external IPv4 address to send to the client in the Passive Mode command.
Also, I have added support for an
optionsobject to be passed, so that the initial current working directory of the server can be overridden.