Improvements to the BDD tests to better tests the compiler and runtimes, reduce interpreter runs, and speed it up a bit (while the compiler path slows it back down) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es, reduce interpreter runs, and speed it up a bit (while the compiler path slows it back down)
depombo
reviewed
May 28, 2020
| from @std/app import start, print, exit | ||
| on start { | ||
| print('Hello, World') | ||
| emit exit 0 | ||
| } | ||
| " | ||
| } | ||
| Before before | ||
| BeforeAll before |
There was a problem hiding this comment.
does switching to BeforeAll and AfterAll speed things up?
There was a problem hiding this comment.
Yes, it only runs the compilation step once per block.
bdd/spec/007_comparator_spec.sh
Outdated
| When run alan-interpreter interpret temp.ln | ||
| It "runs js" | ||
| When run node temp.js | ||
| The output should eq "false |
There was a problem hiding this comment.
is there a way to store this string in a variable and reuse it?
| @@ -820,7 +820,7 @@ pub static OPCODES: Lazy<HashMap<i64, ByteOpcode>> = Lazy::new(|| { | |||
| }); | |||
| cpu!("andbool", |args, mem_frag, _, _| { | |||
| let a = mem_frag.read(args[0], 1)[0]; | |||
| let b = mem_frag.read(args[0], 1)[0]; | |||
| let b = mem_frag.read(args[1], 1)[0]; | |||
There was a problem hiding this comment.
it is kinda nice to be able to make small changes that span multiple repos
There was a problem hiding this comment.
One of the wins of a monorepo, for sure.
depombo
approved these changes
May 28, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.