Fix benchmarks on windows #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how much of this slowdown is due to Windows, how much is due to this being a NUC (though it's got a good SSD, 32GB of RAM, etc...), etc, but the benchmarks take 50% more time and the test suite is about 150% slower, and these two have to run sequentially, taking the testing time up from 4 minutes to 11 minutes. :/ But it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that I have a little Intel NUC to use for testing Windows, I manually tested and noticed a small problem with the benchmarks. This should fix that and also enable testing with it. Since I have only one Windows machine, I have also trimmed the work done on Windows vs Linux to try and reduce an increase in latency. I have also forced the normal testing path to use Linux so it doesn't accidentally clog up the Windows machine's queue.