add support for active and fail offsets #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alantoa Have you had a chance to look at this? :) |
|
@alantoa ? :) |
|
Hey @jacobmolby, I apologize for the delayed response as I was busy. I'll take a look and test it today, but currently it looks good to me. |
|
Thanks, no worries. It's much easier to see the changes with "hide whitespace": |
|
@jacobmolby LGTM, thanks! just released it in v2.4.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for providing active and fail offsets to the gesture.
Very useful when used inside other GestureHandlers or scrollable containers.