Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL support? #57

Closed
asanand opened this issue Jun 6, 2013 · 8 comments
Closed

SSL support? #57

asanand opened this issue Jun 6, 2013 · 8 comments

Comments

@asanand
Copy link
Contributor

asanand commented Jun 6, 2013

I was wondering if it supports SSL. I guess rabbitmq-c supports SSL currently, though I havent tried it.

@alanxz
Copy link
Owner

alanxz commented Jun 6, 2013

Not yet. It is on the TODO list though.

@asanand
Copy link
Contributor Author

asanand commented Jun 6, 2013

I see, just wondering if there is some work in progress (in form of some patch) that can be used

@alanxz
Copy link
Owner

alanxz commented Jun 6, 2013

Not yet. Though this is a fairly simple thing to add to SimpleAmqpClient

@asanand asanand closed this as completed Jun 17, 2013
@asanand
Copy link
Contributor Author

asanand commented Jun 17, 2013

Hi Alan,

I created a patch for SSL support. It seems to work, please take a look and
let me know any changes that needs to be done (e.g., ordering of arguments
or any thing else). I hope it can be integrated.

Thanks,
Ashok

On Thu, Jun 6, 2013 at 8:47 PM, Alan Antonuk notifications@github.comwrote:

Not yet. Though this is a fairly simple thing to add to SimpleAmqpClient


Reply to this email directly or view it on GitHubhttps://github.com//issues/57#issuecomment-19052367
.

@alanxz
Copy link
Owner

alanxz commented Jun 17, 2013

Could you open a pull request against the my fork of SimpleAmqpClient so I can review the patch?

@asanand
Copy link
Contributor Author

asanand commented Jun 19, 2013

I am having some issues in pushing my patch - it says " Permission to alanxz/SimpleAmqpClient.git denied to asanand" . On further google search, "https://help.github.com/articles/error-permission-to-user-repo-denied-to-other-user", it seems that you would probably need to add my account as collaborator, etc. please take a look.

@alanxz
Copy link
Owner

alanxz commented Jun 19, 2013

Follow this guide (you need to fork SimpleAmqpClient, then submit a Pull Request from your fork):

https://help.github.com/articles/using-pull-requests

@asanand
Copy link
Contributor Author

asanand commented Jun 20, 2013

I see.. thanks, that worked. Just submitted pull request.

On Wed, Jun 19, 2013 at 9:41 PM, Alan Antonuk notifications@github.comwrote:

Follow this guide (you need to fork SimpleAmqpClient, then submit a Pull
Request from your fork):

https://help.github.com/articles/using-pull-requests


Reply to this email directly or view it on GitHubhttps://github.com//issues/57#issuecomment-19694487
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants