Disable SIGPIPE on sockets (Issue #23) #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use setsockopt(SO_NOSIGPIPE) on platforms that don't have MSG_NOSIGNAL and do have SO_NOSIGPIPE
alanxz
added a commit
that referenced
this pull request
Jun 6, 2012
Disable SIGPIPE on sockets (Issue #23)
| # define MSG_NOSIGNAL 0x0 | ||
| #endif | ||
|
|
||
| #if defined(SO_NOSIGPIPE) && !defined(MSG_NOSIGNAL) |
There was a problem hiding this comment.
This condition is never true: MSG_NOSIGNAL is always defined because of the lines 58-60.
Lines 58-60 should be after this test.
|
On MacOSX the process sometimes receives SIGPIPES. They disappear if we manually set SO_NOSIGPIPE with setsockopt() on the socketfd. version 0.3.0 |
|
@triccardi-systran - good catch. I've opened a new issue #102 to track this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #23
Disable
SIGPIPEsignaling on sockets owned by the library by settingMSG_NOSIGNALon linux andSO_NOSIGPIPEon BSD variants, Win32 doesn't haveSIGPIPEits ignored.Not using the
signal(SIGPIPE, SIG_IGN)as that affects the entire process and a process may have other pipes it wants to be signaled on.