Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to install or not the static library #749

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

remicollet
Copy link

New version of #665

This fixes an issue for downstream distribution, where static libraries are discouraged

For now (v0.10.0) we have to use BUILD_TESTS + BUILD_STATIC_LIBS to be able to run the test suite
and to exclude librabbitmq.a from the package

BUT installed cmake files contain references to the static library, so are (probably) unusable

This trivial fix allow to build but not install the static library, thus cmake files are clean.

@alanxz
Copy link
Owner

alanxz commented Feb 1, 2023

I will accept this as a short-term fix.

Long term I intend on making the build system generate either shared or static libraries - so this CMake option may go away before the next tagged release.

@alanxz alanxz merged commit ea14216 into alanxz:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants