Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghc-paths
makes downstream executables non portable #96But the ghcWrapper is used in:
parseModuleFromString
andparseModuleApiAnnsWithCpp
inLanguage.Haskell.GHC.ExactPrint.Parsers
Test.Transform
(we dont have to worry about those ones)InsertSignature
(it is an example and we can ignore them)Create duplicate versions of both parse* and push them downstream (in the lib and the downstream packages) will be non trivial.
Using the system env as a global variable is dirty (but arguably better than the fixed at compiled time actual libdir) but quick and dont require changes in downstream packages.
I am not pride of this so i will understand if it is not accepted 😄