Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no need for paramenter "q" in searchAdvanced() #43

Closed
fabnoe opened this issue Nov 26, 2016 · 7 comments
Closed

no need for paramenter "q" in searchAdvanced() #43

fabnoe opened this issue Nov 26, 2016 · 7 comments

Comments

@fabnoe
Copy link

fabnoe commented Nov 26, 2016

This condition is not nesseccary and should be removed. Use case: Get a list of videos for a given channel id.

        if (empty($params) || !isset($params['q'])) {
            throw new \InvalidArgumentException('at least the Search query must be supplied');
        }
@alaouy
Copy link
Owner

alaouy commented Nov 28, 2016

@fabnoe can you please do it in a pull request and provide a test for this ?

@fabnoe
Copy link
Author

fabnoe commented Dec 3, 2016

Sorry. I am not that familiar with pull requests and tests.

@tylergets
Copy link
Contributor

I just ran into this as well. I can provide a PR, but I'm not sure how to add a test removing a unneeded feature.

@alaouy
Copy link
Owner

alaouy commented Feb 10, 2017

@tylergets just make the PR I will handle the test for this one

@tylergets
Copy link
Contributor

@alaouy please see PR #53

@tylergets
Copy link
Contributor

tylergets commented Feb 13, 2017

@alaouy could you attach a tag to the latest commit then this issue should be able to be closed

@alaouy
Copy link
Owner

alaouy commented Feb 13, 2017

@tylergets the v1.2.3 is now available for download 🚀

@alaouy alaouy closed this as completed Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants