Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding a new (not null) column to the users table, it breaks registration with no error #18

Closed
alarner opened this issue May 4, 2016 · 2 comments
Labels

Comments

@alarner
Copy link
Owner

alarner commented May 4, 2016

The default registration page and post /auth/register route should return better errors, notifying the developer that a required field was not specified.

For example, create a migration that adds a required (not null) username column to the users table. Run that migration and try to register. Registration fails with no error.

What should happen:

Registration should fail, but it should show a database error or text error giving the developer some information on why the error occurred.

@alarner alarner added the bug label May 4, 2016
@alarner
Copy link
Owner Author

alarner commented May 4, 2016

Also there is an issue with the registration. It should be updated to be more flexible so that it doesn't require updating /auth/register route

@alarner alarner mentioned this issue May 5, 2016
@alarner
Copy link
Owner Author

alarner commented May 14, 2016

Fixed by #20 and #22

@alarner alarner closed this as completed May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant