Fix independent test running (#211) #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alastair Porter <alastair@porter.net.nz>
These tests worked when run in the same context as other tests, but when run independently would fail. Fixes #211 Signed-off-by: Alastair Porter <alastair@porter.net.nz>
Signed-off-by: Alastair Porter <alastair@porter.net.nz>
I don't think this would be a problem for this test suite because it runs in about a second and those operations wouldn't increase that time significantly. You could get all fancy with mixins to only add it to those classes that need it, but I don't think that's worth the trouble.
LGTM otherwise. |
mineo
added a commit
that referenced
this pull request
Dec 20, 2016
Fix independent test running (#211) Signed-off-by: Wieland Hoffmann <themineo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
Now tests work when run independently.
I thought about adding a parent testcase class which set client/auth in the
setUpand back to empty intearDown, but I wasn't sure if it was a good idea to do it in all tests even if they didn't use that functionality.(Also, how do you do
supercompatible with python2 and python3?)