Default to use MusicBrainz and CAA over HTTPS #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new "global" `https` boolean variable. This variable will be True by default, but if `set_hostname()` gets called it will default to False. This should allow both using musicbrainz.org over HTTPS by default, but anyone that have a script setting a custom server (that may not support HTTPS) will continue to work as well. Fixes alastair#197 Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
This adds a new "global" `https` boolean variable. This variable will be True by default, but if `set_hostname()` gets called it will default to False. This should allow both using coverartarchive.org over HTTPS by default, but anyone that have a script setting a custom server (that may not support HTTPS) will continue to work as well. Related to alastair#197 Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
|
This solution looks very clean, minimal and backwards-compatible. |
Signed-off-by: Alastair Porter <alastair@porter.net.nz>
by default with musicbrainz.org we use https Signed-off-by: Alastair Porter <alastair@porter.net.nz>
Signed-off-by: Alastair Porter <alastair@porter.net.nz>
|
I've updated this, a revision by someone else would be welcome! |
Signed-off-by: Alastair Porter <alastair@porter.net.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new "global"
httpsboolean variables. This variable will be True by default, but ifset_hostname()gets called it will default to False. This should allow both usingmusicbrainz.org/coverartarchive.orgover HTTPS by default, but anyone that have a script setting a custom server (that may not support HTTPS) will continue to work as well.I didn't see anywhere to denote that Python 2.7.6 would be the minimal supported version for this (as per my comment: #197 (comment)).
Should resolve #197