Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of genres. #266

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix parsing of genres. #266

wants to merge 3 commits into from

Conversation

aereaux
Copy link

@aereaux aereaux commented Oct 23, 2020

Currently they don't seem to get returned.

This was taken from #247

Signed-off-by: Aidan Epstein aidan@jmad.org

Currently they don't seem to get returned.

Signed-off-by: Aidan Epstein <aidan@jmad.org>
@clang13
Copy link

clang13 commented Nov 26, 2021

What needs to happen to merge and release this PR? It does appear that genre support does not work without this fix.

Signed-off-by: Alastair Porter <alastair@porter.net.nz>
Signed-off-by: Alastair Porter <alastair@porter.net.nz>
@alastair
Copy link
Owner

Thanks for the start on this work! I made a small change to also include the genre id attribute

@aereaux
Copy link
Author

aereaux commented Jan 16, 2022

Great, thanks for maintaining this! Anything else I'd need to do for it to be merged?

@deckgamez
Copy link

Any update to this one?

@vinyllionel
Copy link

@aereaux @alastair can one of you please fix ASAP? my grandfather just lost several evenings worth of manual tagging due to this issue and some tools that rely on these bindings.

i'm restoring from a backup from last monday, but that's still 18-20 hours of lost work.

please fix this, get the fix merged, and release a new version asap. this is causing data loss.

@kongwak
Copy link

kongwak commented Apr 11, 2022

Is there a release planned for this? It would be very nice have.

@mtrolley
Copy link

Any chance of this PR being merged soon? It's coming up on 2 years old.

@Seqularise
Copy link

here is a patched PKGBUILD with this for those who are on arch, quick solution until this will get merged
https://pastebin.com/PK6VtyU7

@kongwak
Copy link

kongwak commented Jul 11, 2022

Is this going to make the next release of beets? As it stands, there a no very reliable options for adding genres in beets.

@mtrolley
Copy link

Is this going to make the next release of beets? As it stands, there a no very reliable options for adding genres in beets.

It would need to be merged and a new tag created.

@vinyllionel
Copy link

Hi @alastair, can you merge this? We're only a few months away from this being 2 years old.

@calm3285
Copy link

this issue is 3 years old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants