Minor fix: artist-credit entries attached to track structures #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Track records, in addition to title, can have an artist field as well. This is useful for things like the Classical Style Guide, which says the track artist should be the composer but the recording artist should be the performers. Signed-off-by: Galen Hazelwood <galenhz@gmail.com>
|
This looks pretty good to me. There may be a parallel of #72 here though, where we should copy the recording AC to the track AC if there isn't one for the track (which looks to be the semantics of the WS, comparing http://beta.musicbrainz.org/ws/2/release/833d4c3a-2635-4b7a-83c4-4e560588f23a?inc=recordings+artist-credits and http://beta.musicbrainz.org/ws/2/release/fbe4490e-e366-4da2-a37a-82162d2f41a9?inc=recordings+artist-credits ). Nevertheless, +1 for merging. |
|
Thanks for this. Ian is right, we should pull artist-credit into the |
alastair
added a commit
that referenced
this pull request
Jun 17, 2012
Fixes #72, Addition to #75 Adds a field track_or_recording_length to tracks that contains either the track length or, if not present, the recording length Copies artist-credit from recording always, unless it's different to the track artist-credit Signed-off-by: Alastair Porter <alastair@porter.net.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track records, in addition to title, can have an artist field as well. This is useful
for things like the Classical Style Guide, which says the track artist should be the
composer but the recording artist should be the performers.
Signed-off-by: Galen Hazelwood galenhz@gmail.com