Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting support for OAuth2 #93

Closed
wants to merge 3 commits into from
Closed

Starting support for OAuth2 #93

wants to merge 3 commits into from

Conversation

duailibe
Copy link

This is the start of the implementation of the support for the OAuth protocol (related to issue #89). This isn't actually completed yet, I'll still work on it for the next days, but I thought it would be good to hear some suggestions and have others contributing while still in the beginning.

I just implemented the first transactions between the server to establish authorization of some application but it still needs some error handling. And, most important, there's need to include the support for the rest of the API operations, by sending the access token.

First, I started following the same implementation before (global variables) but then I thought to do it the best way.

@alastair
Copy link
Owner

wow, great! thanks for this. I'll take a look at it as you add more functionality and let you know if I have any comments

@sampsyo
Copy link
Collaborator

sampsyo commented Mar 12, 2013

Very nice, @duailibe. This implementation is very straightforward; it seems we don't even really need a dependency on an OAuth2 library (as I would have expected). Cool!

@duailibe
Copy link
Author

@alastair please, let me know of any improvements.

@sampsyo I first tried to work out with OAuth2 library, but it seemed too "overkill" for something rather simple. But if anyone thinks it's best to use it, I don't really think it's a bad idea.

@sampsyo
Copy link
Collaborator

sampsyo commented Mar 12, 2013

This seems like a great way to go if it works and remain simple. (I know there are lots of broken OAuth2 libraries out there for Python, so this way we benefit from avoiding those.)

@alastair
Copy link
Owner

My only concern with spinning our own would be if we inadvertently made any
"common" implementation errors in the process. If you can show that this
isn't the case then I'm OK with it.

On Wed, Mar 13, 2013 at 12:02 AM, Adrian Sampson
notifications@github.comwrote:

This seems like a great way to go if it works and remain simple. (I know
there are lots of broken OAuth2 libraries out there for Python, so this way
we benefit from avoiding those.)


Reply to this email directly or view it on GitHubhttps://github.com//pull/93#issuecomment-14811608
.

@sampsyo
Copy link
Collaborator

sampsyo commented Mar 13, 2013

👍 to that.

@duailibe duailibe closed this May 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants