-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style ci update #23
Style ci update #23
Conversation
I see that it's working as intended. |
The |
Do you want to make a separate PR with only the CI and formatting change? Would probably be able to get that merged in quickly. |
I have added ignore on Sure I will just remove |
I don’t think I understand. Why can’t you run tests locally?
…On Sat, Apr 27, 2024 at 18:57 Slawek Bierwiaczonek ***@***.***> wrote:
I have added ignore on flaky because at the moment tests can't be run
locally so there is no reason (but only temporary) to install flaky and
when it's not installed then pyright throws an error about it.
Sure I will just remove README.md from this PR and put it in separate one.
—
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANDAH5N63EKBYRBEQ6ELPHTY7NZCBAVCNFSM6AAAAABG36JTPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBQGQZTOMJUGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Because there are no local tests written yet, only with live API. Matter that we discussed in #10 |
I see. It sounds like you prefer to keep I think for future contributors, it'd be good if PyRight catches something that breaks tests rather than not. Also since we might have flaky tests that don't depend on Anthropic API in the future, I think it's reasonable for missing flaky to raise a problem. If your problem with that line is purely local, I'd lean toward not type ignoring that line. |
I rolled back that specific change for now. We can discuss more if you feel strongly! Good job on the PR :) |
black
command to check code. If it will find any files that need formatting it will fail CI.type: ignore
on missing import insimple_tests.py